Re: [PATCH] bus: simple-pm-bus: convert bool SIMPLE_PM_BUS to tristate
From: Rafael J. Wysocki
Date: Sun Dec 17 2017 - 13:02:04 EST
On Friday, December 1, 2017 8:02:33 AM CET Simon Horman wrote:
> On Thu, Nov 30, 2017 at 12:57:00PM +0100, Geert Uytterhoeven wrote:
> > From: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> > The Kconfig currently controlling compilation of this code is:
> > config SIMPLE_PM_BUS
> > bool "Simple Power-Managed Bus Driver"
> > ...meaning that it currently is not being built as a module by anyone.
> > In removing the orphaned modular support in a previous patch set,
> > Geert indicated he'd rather see this code converted to tristate.
> > I normally don't do that because it extends functionality that I
> > can't easily run time test or even know if the use case makes sense,
> > but since in this case the author has nominated it as such, we do
> > the conversion here.
> > Note that doesn't change the lack of run time testing ; this change
> > is only tested for sucessful compile and modpost.
> > [geert: Ethernet is probed successfully on sh73a0/kzm9g after
> > insmodding simple-pm-bus.ko]
> > Cc: Kevin Hilman <khilman@xxxxxxxxxx>
> > Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Signed-off-by: Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx>
> > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Acked-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>