Re: [PATCH 1/5] media: rc: update sunxi-ir driver to get base clock frequency from devicetree

From: Philipp Rossak
Date: Mon Dec 18 2017 - 07:44:20 EST

Hey Andi,

thanks for the feedback. I will fix that in the next version of this patch series!

On 18.12.2017 03:44, Andi Shyti wrote:
Hi Philipp,

just a couple of small nitpicks.

+ u32 b_clk_freq;


+ /* Base clock frequency (optional) */
+ if (of_property_read_u32(dn, "clock-frequency", &b_clk_freq)) {
+ b_clk_freq = SUNXI_IR_BASE_CLK;
+ }

how about you intialize 'b_clk_freq' to 'SUNXI_IR_BASE_CLK' and
just call 'of_property_read_u32' without if statement.
'b_clk_freq' value should not be changed if "clock-frequency"
is not present in the DTS.

This might avoid misinterpretation from static analyzers that
might think that 'b_clk_freq' is used uninitialized.

+ dev_info(dev, "set base clock frequency to %d Hz.\n", b_clk_freq);

Please use dev_dbg().