Re: [PATCH] x86: move parse_early_param to earlier code for add_efi_memmap

From: Matt Fleming
Date: Mon Dec 18 2017 - 08:11:29 EST


On Sat, 16 Dec, at 03:06:32PM, Ingo Molnar wrote:
>
> * Matt Fleming <matt@xxxxxxxxxxxxxxxxxxx> wrote:
>
> > > x86_init.oem.arch_setup();
> > > @@ -962,6 +959,8 @@ void __init setup_arch(char **cmdline_p)
> > >
> > > parse_early_param();
> > >
> > > + if (efi_enabled(EFI_BOOT))
> > > + efi_memblock_x86_reserve_range();
> > > #ifdef CONFIG_MEMORY_HOTPLUG
> > > /*
> > > * Memory used by the kernel cannot be hot-removed because Linux
> > >
> >
> > I prefer this version. Please re-send a full patch and update the
> > subject line to include the "fix" somewhere; it wasn't obvious to me
> > from the start that this is a bug fix.
>
> Agreed.
>
> I dropped the commit I just applied to tip:efi/core, since you are handling this,
> so this patch should come through the regular EFI channels, right?

Yep, that's right. Me or Ard will take care of it.