Re: [PATCH v5 0/8] omap: dmtimer: Move driver out of plat-omap
From: Ladislav Michl
Date: Mon Dec 18 2017 - 08:14:18 EST
On Mon, Dec 18, 2017 at 06:24:42PM +0530, Keerthy wrote:
> On Monday 18 December 2017 04:46 PM, Ladislav Michl wrote:
> > Keerthy,
> >
> > On Tue, Dec 12, 2017 at 11:42:09AM +0530, Keerthy wrote:
> >> The series moves dmtimer out of plat-omap to drivers/clocksource.
> >> The series also does a bunch of changes to pwm-omap-dmtimer code
> >> to adapt to the driver migration and clean up plat specific
> >> pdata-quirks and use the dmtimer platform data.
> >
> > thanks for nice work. I'll send two more patches as a reply to this
> > one. I'd be glad if you could make them part of your serie. One of
> > them would be nice to have for pwm driver prescaler fix which will
> > be send independently.
> > Also, if that helps you can have my
> > Tested-by: Ladislav Michl <ladis@xxxxxxxxxxxxxx>
> > on IGEPv2 (OMAP3430 based)
>
> Thanks a bunch! :-). I will take the pwm driver fix along with mine.
>
> should i also take the two patches which you sent:
>
> [PATCH 1/2] clocksource: timer-dm: Make unexported functions static
> [PATCH 2/2] clocksource: timer-dm: Check prescaler value
It would be great, if you could add those above to your serie.
> Also what about this:
> [PATCH] pwm: omap-dmtimer: Fix frequency when using prescaler
This one is independent of your serie, just "[PATCH 2/2] clocksource:
timer-dm: Check prescaler value" makes it a bit more error prone,
but there is no compile nor runtime dependency.
Perhaps it could me merged directly via pwm tree after some review?
I have few more patches to add event capture support, based on top
of those already sent, which I'll send separately.
> Let me know. I plan to send v6 with your Tested-by.
>
> Thanks,
> Keerthy
Thank you,
ladis