Re: jsm_tty: Deletion of a null pointer check in two functions?
From: Guilherme G. Piccoli
Date: Mon Dec 18 2017 - 09:36:32 EST
On 12/16/2017 04:27 AM, SF Markus Elfring wrote:
>> Thanks for the fix.
>
> Thanks for your positive feedback.
>
>
>> I was on vacation - but now seeing all the analysis made here,
>
> I assume that special communication settings could trigger
> corresponding consequences for the discussed source code adjustment.
>
>
>> if "ch" can't be NULL then please go ahead and remove the check =)
>
> Would you dare to convert this request into a concrete patch?
For me, it's OK if you send the patch or I can do it myself.
It's a minor patch...but it's correct the way I see it.
So, what do you prefer? Send it yourself, or want me to send
it with your sign-off too? (since was your idea).
Thanks,
Guilherme
>
> Regards,
> Markus
>