[PATCH 4.9 129/177] badblocks: fix wrong return value in badblocks_set if badblocks are disabled

From: Greg Kroah-Hartman
Date: Mon Dec 18 2017 - 12:08:43 EST

4.9-stable review patch. If anyone has any objections, please let me know.


From: Liu Bo <bo.li.liu@xxxxxxxxxx>

[ Upstream commit 39b4954c0a1556f8f7f1fdcf59a227117fcd8a0b ]

MD's rdev_set_badblocks() expects that badblocks_set() returns 1 if
badblocks are disabled, otherwise, rdev_set_badblocks() will record
superblock changes and return success in that case and md will fail to
report an IO error which it should.

This bug has existed since badblocks were introduced in commit
9e0e252a048b ("badblocks: Add core badblock management code").

Signed-off-by: Liu Bo <bo.li.liu@xxxxxxxxxx>
Acked-by: Guoqing Jiang <gqjiang@xxxxxxxx>
Signed-off-by: Shaohua Li <shli@xxxxxx>
Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
block/badblocks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/block/badblocks.c
+++ b/block/badblocks.c
@@ -178,7 +178,7 @@ int badblocks_set(struct badblocks *bb,

if (bb->shift < 0)
/* badblocks are disabled */
- return 0;
+ return 1;

if (bb->shift) {
/* round the start down, and the end up */