Re: [PATCH] net: qcom/emac: Change the order of mac up and sgmii open

From: David Miller
Date: Mon Dec 18 2017 - 13:23:21 EST

From: Hemanth Puranik <hpuranik@xxxxxxxxxxxxxx>
Date: Mon, 18 Dec 2017 11:27:47 +0530

> This patch fixes the order of mac_up and sgmii_open for the
> reasons noted below:
> - If open takes more time(if the SGMII block is not responding or
> if we want to do some delay based task) in this situation we
> will hit NETDEV watchdog
> - The main reason : We should signal to upper layers that we are
> ready to receive packets "only" when the entire path is initialized
> not the other way around, this is followed in the reset path where
> we do mac_down, sgmii_reset and mac_up. This also makes the driver
> uniform across the reset and open paths.
> - In the future there may be need for delay based tasks to be done in
> sgmii open which will result in NETDEV watchdog
> - As per the documentation the order of init should be sgmii, mac, rings
> and DMA
> Signed-off-by: Hemanth Puranik <hpuranik@xxxxxxxxxxxxxx>