Re: [PATCH] clk: check ops pointer on clock register

From: Stephen Boyd
Date: Mon Dec 18 2017 - 14:03:12 EST

On 12/18, Jerome Brunet wrote:
> Nothing really prevents a provider from (trying to) register a clock
> without providing the clock ops structure.
> We do check the individual fields before using them, but not the
> structure pointer itself. This may have the usual nasty consequences when
> the pointer is dereferenced, mostly likely when checking one the field
> during the initialization.

Yes, that nasty consequence should be a kernel oops, and the
developer should notice that before submitting the driver for
inclusion. I don't think we really care to return an error here
if this happens.

Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project