Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

[Santosh Shilimkar]

On 12/16/2017 6:02 PM, Knut Omang wrote:
> On Sat, 2017-12-16 at 12:00 -0800, santosh.shilimkar@xxxxxxxxxx wrote:
> > On 12/16/17 10:24 AM, Joe Perches wrote:

[...]
> > > Most of these existing messages from checkpatch should
> > > probably be inspected and corrected where possible to
> > > minimize the style differences between this subsystem
> > > and the rest of the kernel.
> > >
> > > For instance, here's a trivial patch to substitute
> > > pr_<level> for printks and a couple braces next to
> > > these substitutions.
> > Thanks Joe. I actually had a similar patch a while back but
> > since it was lot of churn, and code was already merged,
> > never submitted it and then later forgot about it.
> >
> > Will look into it.
>
> Please look at my set here first - I have already spent considerable time cleaning up
> stuff while working on this:

Just closing the loop. As discussed, I can use your patches without
any new tool dependency since existing checkpatch.pl already gives
those warnings. I started picking up Joes patch but since you have
changes, can use them instead once you untie them with runcheck.

Regarding the $subject, just re-iterating that I don't want any custom
script for RDS and want to just follow generic guidelines followed by
netdev for all net/* code.

Regards,
Santosh