Re: [alsa-devel][PATCH v6] ASoC: TSCS42xx: Support Tempo Semiconductor's TSCS42xx audio CODECs

[Steven Eckhoff]

On Mon, Dec 18, 2017 at 09:50:48AM +0000, Charles Keepax wrote:

> Is this unused?

I apologize I missed this. These were going to be mux controls for two
differential inputs. There are two inputs, but only one can be used at
a time. We have never seen anybody use the second input, so I will
remove the mux controls since it is likely just going to be noise to
anybody configuring the chip through these controls.

> Given all users of this macro use coeff_ram_get and coeff_ram_put
> might it just be worth sticking them in here?

Good point. In the next version the callbacks will be implied through
the use of the macro.

> Other than those two very minor comments, looks ok to me so I
> think you can add:
> 
> Reviewed-by: Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx>
> 
> Thanks,
> Charles

Thank you so much for your time on this review. It has really helped
improve the driver.