Re: [PATCH 1/2] rtc-r7301: Fix a possible sleep-in-atomic bug in rtc7301_read_time
From: Alexandre Belloni
Date: Mon Dec 18 2017 - 17:24:54 EST
On 13/12/2017 at 21:55:50 +0800, Jia-Ju Bai wrote:
> The driver may sleep under a spinlock.
> The function call path is:
> rtc7301_read_time (acquire the spinlock)
> usleep_range --> may sleep
> To fix it, usleep_range is replaced with udelay.
> This bug is found by my static analysis tool(DSAC) and checked by my code review.
> Signed-off-by: Jia-Ju Bai <baijiaju1990@xxxxxxxxx>
> drivers/rtc/rtc-r7301.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering