Re: [PATCH 0/5] staging: rtl8712: fix several checkpatch style issues
From: Joe Perches
Date: Mon Dec 18 2017 - 17:28:40 EST
On Mon, 2017-12-18 at 23:17 +0100, Martin Homuth wrote:
> On 12/18/2017 10:21 PM, Joe Perches wrote:
> > On Mon, 2017-12-18 at 21:36 +0100, Martin Homuth wrote:
> > > This patch series fixes some coding style issues reported by checkpatch.pl.
> > >
> > > It is based on next-20171218
> > >
> > > Martin Homuth (5):
> > > staging: rtl8712: style fix over 80 characters warnings
> > > staging: rtl8712: style fix multiple line dereferences
> > > staging: rtl8712: style fix indentation
> > > staging: rtl8712: style fix unneeded else
> > > staging: rtl8712: style fix returned error code
> > >
> > > drivers/staging/rtl8712/ieee80211.c | 6 ++-
> > > drivers/staging/rtl8712/os_intfs.c | 5 +-
> > > drivers/staging/rtl8712/rtl8712_cmd.c | 18 ++++---
> > > drivers/staging/rtl8712/rtl8712_recv.c | 8 +--
> > > drivers/staging/rtl8712/rtl8712_xmit.c | 3 +-
> > > drivers/staging/rtl8712/rtl871x_cmd.c | 36 +++++++-------
> > > drivers/staging/rtl8712/rtl871x_ioctl_linux.c | 72
> > > ++++++++++++++-------------
> > This line wrapping is generally an indication that your email
> > client (thunderbird 52.5.0) is wrapping all patches.
> > If you can, use git send-email instead
> Thank you very much, I wasn't aware of this problem and finally set up
> send-email appropriately. Should I resend the series right away or wait
> for additional comments?
I never looked at the patches.
The subjects look innocuous enough though.
I'd just resend as V2 after first resending only to
yourself to make sure the patches apply properly.