Re: [PATCH 02/13] powerpc/powernv: Set correct configuration space size for opencapi devices

From: Andrew Donnellan
Date: Mon Dec 18 2017 - 20:15:12 EST

On 19/12/17 02:21, Frederic Barrat wrote:
From Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx>

Good try :) That should be "From: ..."

git format-patch/send-email will handle this automatically if the commit author is set correctly, ie:

git commit --amend --author="Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx>"

The configuration space for opencapi devices doesn't have a PCI
Express capability, therefore confusing linux in thinking it's of an
old PCI type with a 256-byte configuration space size, instead of the
desired 4k. So add a PCI fixup to declare the correct size.

Signed-off-by: Andrew Donnellan <andrew.donnellan@xxxxxxxxxxx>
Signed-off-by: Frederic Barrat <fbarrat@xxxxxxxxxxxxxxxxxx>
arch/powerpc/platforms/powernv/pci-ioda.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c b/arch/powerpc/platforms/powernv/pci-ioda.c
index c37b5d288f9c..b8ec76aa266f 100644
--- a/arch/powerpc/platforms/powernv/pci-ioda.c
+++ b/arch/powerpc/platforms/powernv/pci-ioda.c
@@ -4079,6 +4079,16 @@ void __init pnv_pci_init_npu2_opencapi_phb(struct device_node *np)
pnv_pci_init_ioda_phb(np, 0, PNV_PHB_NPU_OCAPI);

+static void pnv_npu2_opencapi_cfg_size_fixup(struct pci_dev *dev)
+ struct pci_controller *hose = pci_bus_to_host(dev->bus);
+ struct pnv_phb *phb = hose->private_data;
+ if (phb->type == PNV_PHB_NPU_OCAPI)
+ dev->cfg_size = PCI_CFG_SPACE_EXP_SIZE;
+DECLARE_PCI_FIXUP_EARLY(PCI_ANY_ID, PCI_ANY_ID, pnv_npu2_opencapi_cfg_size_fixup);
void __init pnv_pci_init_ioda_hub(struct device_node *np)
struct device_node *phbn;

Andrew Donnellan OzLabs, ADL Canberra
andrew.donnellan@xxxxxxxxxxx IBM Australia Limited