RE: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5

From: SZ Lin (æäæ)
Date: Tue Dec 19 2017 - 01:05:17 EST

> -----Original Message-----
> From: BjÃrn Mork [mailto:bjorn@xxxxxxx]
> Sent: Tuesday, December 19, 2017 2:44 AM
> To: SZ Lin (æäæ)
> Cc: Johan Hovold; Taiyi TY Wu (åææ); Greg Kroah-Hartman;
> linux-usb@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] USB: serial: option: adding support for YUGA CLM920-NC5
> Johan Hovold <johan@xxxxxxxxxx> writes:
> >> +static const struct option_blacklist_info yuga_clm920_nc5_blacklist = {
> >> + .reserved = BIT(0) | BIT(1) | BIT(4), };
> >
> > Do you really need to blacklist the first interface?
> Good question. Interface #0 does look a lot like a Qualcomm DM/DIAG function, based
> on two bulk endpoints, no additional descriptors and the fact that it is the first interface.
> If so, then we do want a serial driver for it. There is a basic libqcdm implementation in
> ModemManager if you want to test it out.

I have confirmed that interface #0 is QCDM/DIAG port in this module, and thus I will remove this from reserved list in next patch.
Furthermore, interface #1 is ADB port. Should I also remove this from reserved list?

> And I expect interface #4 is QMI/rmnet? Feel free to confirm that assumption with a
> patch against qmi_wwan :-)
Yes, it is. I will send qmi_wwan patch by all means.
> BjÃrn