Re: [PATCH for-4.15] ASoC: rt5514: don't assume rt5514 component was "attached"
From: Cheng-yi Chiang
Date: Tue Dec 19 2017 - 02:39:09 EST
Hi Brian, I am sorry for not using the plain text mode in the previous mail.
I agree with you on other points.
On Tue, Dec 19, 2017 at 1:42 AM, Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> Hi!
>
> (By the way, your mail is HTML and likely will get rejected by many
> mailing lists and/or people reading these mailing lists.)
>
> On Mon, Dec 18, 2017 at 12:23:18PM +0800, Cheng-yi Chiang wrote:
>> Hi Brian,
>> Oder has posted the same fix : [1]https://patchwork.kernel.org/
>> patch/10066257/ and it has been applied.
>
> OK cool. Obviously I'm biased, but I prefer mine, as it has less
> needless whitespace, and is appropriately documented ;) But it should be
> a fine replacement.
>
>> Perhaps you can cherry-pick it to v4.15 ?
>
> I have no say in that; that would be up to Mark, I think. It's most
> certainly a regression in 4.15-rc1, so IMO it should be given a proper
> 'Fixes: e9c50aa6bd39 ("ASoC: rt5514-spi: check irq status to schedule
> data copy in resume function")' tag and sent for 4.15, not 4.16.
>
> Brian