Re: [PATCH V4 02/26] powerpc/PCI: deprecate pci_get_bus_and_slot()

From: Michael Ellerman
Date: Tue Dec 19 2017 - 05:29:21 EST


Sinan Kaya <okaya@xxxxxxxxxxxxxx> writes:

> pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as
> where a PCI device is present. This restricts the device drivers to be
> reused for other domain numbers.
>
> Getting ready to remove pci_get_bus_and_slot() function in favor of
> pci_get_domain_bus_and_slot().
>
> Use pci_get_domain_bus_and_slot() with a domain number of 0 as the code
> is not ready to consume multiple domains and existing code used domain
> number 0.
>
> Signed-off-by: Sinan Kaya <okaya@xxxxxxxxxxxxxx>
> ---
> arch/powerpc/kernel/pci_32.c | 3 ++-
> arch/powerpc/platforms/powermac/feature.c | 2 +-
> arch/powerpc/sysdev/mv64x60_pci.c | 4 ++--
> 3 files changed, 5 insertions(+), 4 deletions(-)

Looks to do what it says. I don't know if any of these call sites could
be improved to provide the domain, but that's not really your problem.

Acked-by: Michael Ellerman <mpe@xxxxxxxxxxxxxx> (powerpc)

cheers