Re: [PATCH TRIVIAL] PM / wakeup: only recommend "call"ing device_init_wakeup() once

[Rafael J. Wysocki]

On Tuesday, December 19, 2017 12:30:48 AM CET Brian Norris wrote:
> I'll admit admit it: I've written bad driver code that tries to
> configure a device's wake IRQ without having called device_init_wakeup()
> first. But do you really have to ask ask me twice?
> 
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
> ---
>  drivers/base/power/wakeup.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c
> index 38559f04db2c..cb72965b3281 100644
> --- a/drivers/base/power/wakeup.c
> +++ b/drivers/base/power/wakeup.c
> @@ -298,7 +298,7 @@ int device_wakeup_attach_irq(struct device *dev,
>  
>  	ws = dev->power.wakeup;
>  	if (!ws) {
> -		dev_err(dev, "forgot to call call device_init_wakeup?\n");
> +		dev_err(dev, "forgot to call device_init_wakeup?\n");
>  		return -EINVAL;
>  	}
>  
> 

Applied, thanks!