Re: [PATCH 09/45] drivers: media: remove duplicate includes
From: Sakari Ailus
Date: Tue Dec 19 2017 - 05:57:32 EST
On Sun, Dec 10, 2017 at 11:03:29PM +0530, Pravin Shedge wrote:
> On Thu, Dec 7, 2017 at 7:05 PM, Sakari Ailus <sakari.ailus@xxxxxx> wrote:
> > Hi Pravin,
> > On Wed, Dec 06, 2017 at 10:22:02PM +0530, Pravin Shedge wrote:
> >> These duplicate includes have been found with scripts/checkincludes.pl but
> >> they have been removed manually to avoid removing false positives.
> >> Signed-off-by: Pravin Shedge <pravin.shedge4linux@xxxxxxxxx>
> > While at it, how about ordering the headers alphabetically as well? Having
> > such a large number of headers there unordered may well be the reason why
> > they're included more than once...
> > --
> > Sakari Ailus
> > e-mail: sakari.ailus@xxxxxx
> Hi Sakari,
> Sorry for the late reply.
> Ordering the header files alphabetically helps to avoid problems such
> as inclusion of duplicate header files.
> My personal preference is to go from local to global, each subsection
> in alphabetical order.
> Ideally, all header files should be self-contained, and inclusion
> order should not matter.
> Simple reordering the headers should not break build.
> Reordering header files aways helpful for big projects like Linux-Kernel.
> But this requires changes tree wide and modifies lots of files.
> Such change requires huge audience to be participated in discussion &
> take a final call.
Hmm. I'm not quite sure what do you mean. You're already changing the three
files, there's no need to arrange others at the same time.
> With this patch I just handled inclusion of header file multiple times
> to avoid code duplication after preprocessing.
> Thanks & Regards,