Re: [PATCH 0/2] platform/x86/thinkpad_acpi: Adjustments for four function implementations

From: Andy Shevchenko
Date: Tue Dec 19 2017 - 09:37:30 EST

On Mon, Dec 18, 2017 at 11:26 PM, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Mon, 18 Dec 2017 22:23:45 +0100
> Two update suggestions were taken into account
> from static source code analysis.
> Markus Elfring (2):
> Delete an error message for a failed memory allocation in three functions

This one is questionable since it prints error messages at ->init() stage.
I would rather not touch this.

> Improve a size determination in tpacpi_new_rfkill()

Doesn't make any sense right now. One style over the other.
Nothing gets better or worth at this point.

Sorry, but NAK for both.

With Best Regards,
Andy Shevchenko