Re: [resend PATCH 0/2] fix VFS register_shrinker fixup
From: Michal Hocko
Date: Tue Dec 19 2017 - 11:01:21 EST
On Tue 19-12-17 15:34:19, Al Viro wrote:
> On Tue, Dec 19, 2017 at 04:19:15PM +0100, Michal Hocko wrote:
> > Dohh, I have missed resend by Tetsuo http://lkml.kernel.org/r/1513596701-4518-1-git-send-email-penguin-kernel@xxxxxxxxxxxxxxxxxxx
> > (thanks for dropping me from the CC). Al seeemed to take the patch. We
> > still need patch 2. Al, are you going to take it from this thread or you
> > are going to go your way?
> Umm... git log for-linus in vfs.git since yesterday:
> commit 9ee332d99e4d5a97548943b81c54668450ce641b
> Author: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> Date: Mon Dec 18 15:05:07 2017 -0500
> sget(): handle failures of register_shrinker()
> Signed-off-by: Al Viro <viro@xxxxxxxxxxxxxxxxxx>
> commit bb422a738f6566f7439cd347d54e321e4fe92a9f
> Author: Tetsuo Handa <penguin-kernel@xxxxxxxxxxxxxxxxxxx>
> Date: Mon Dec 18 20:31:41 2017 +0900
> mm,vmscan: Make unregister_shrinker() no-op if register_shrinker() failed.
> Syzbot caught an oops at unregister_shrinker() because combination of
> commit 1d3d4437eae1bb29 ("vmscan: per-node deferred work") and fault
> injection made register_shrinker() fail and the caller of
> register_shrinker() did not check for failure.