Re: [PATCH] isdn: avm: Handle return value of skb_dequeue()

From: David Miller
Date: Tue Dec 19 2017 - 11:05:07 EST


From: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>
Date: Sun, 17 Dec 2017 01:17:23 +0530

> skb_dequeue() will return NULL for an empty list or a pointer
> to the head element.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@xxxxxxxxx>

There is no code path where this is possible.

The two call sites:

1) Explicitly add an SKB to the queue

OR

2) Explcitily guard the call with an skb_queue_empty() check

Therefore the stated condition is not possible.