Re: platform/x86/thinkpad_acpi: Adjustments for four function implementations

From: Andy Shevchenko
Date: Tue Dec 19 2017 - 12:28:17 EST

On Tue, Dec 19, 2017 at 6:23 PM, SF Markus Elfring
<elfring@xxxxxxxxxxxxxxxxxxxxx> wrote:
>>> Delete an error message for a failed memory allocation in three functions
>> This one is questionable since it prints error messages at ->init() stage.
>> I would rather not touch this.
> Do you find the Linux allocation failure report insufficient in this case?

It is up to the current driver maintainer. For me it sounds better to
have than not to.

>>> Improve a size determination in tpacpi_new_rfkill()
>> Doesn't make any sense right now. One style over the other.
>> Nothing gets better or worth at this point.
> Would you like to care for a bit more compliance with information
> from the section â14) Allocating memoryâ in the document âcoding-style.rstâ?

You know, in Russian we have an adverb: ÐÐÑÑÐÐÑ ÐÑÑÐÐÐ Ð-ÐÑ ÐÐÐÐÑÑÑÑ,
Which has English equivalent: Give a man enough rope and heâll hang himself.

With Best Regards,
Andy Shevchenko