Re: [PATCH] scsi: storvsc: Fix scsi_cmd error assignments in storvsc_handle_error

From: Stephen Hemminger
Date: Tue Dec 19 2017 - 13:37:21 EST

On Tue, 19 Dec 2017 13:32:48 -0500
Cathy Avery <cavery@xxxxxxxxxx> wrote:

> When an I/O is returned with an srb_status of SRB_STATUS_INVALID_LUN
> which has zero good_bytes it must be assigned an error. Otherwise
> the I/O will be continuously requeued and will cause a deadlock in the
> case where disks are being hot added and removed. sd_probe_async will
> wait forever for its I/O to complete while holding scsi_sd_probe_domain.
> Also returning the default error of DID_TARGET_FAILURE causes
> multipath to not retry the I/O resulting in applications receiving I/O
> errors before a failover can occur.
> Signed-off-by: Cathy Avery <cavery@xxxxxxxxxx>
> Signed-off-by: Long Li <longli@xxxxxxxxxxxxx>

When working on the DVD probe issue I saw that error handling was
problematic. Thanks for fixing.

Reviewed-by: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx>