Re: [PATCH v9 7/7] intel_sgx: in-kernel launch enclave
From: Jarkko Sakkinen
Date: Tue Dec 19 2017 - 18:58:00 EST
On Tue, 2017-12-19 at 17:36 +0200, Andy Shevchenko wrote:
> On Tue, Dec 19, 2017 at 3:59 PM, Jarkko Sakkinen
> <jarkko.sakkinen@xxxxxxxxxxxxxxx> wrote:
> > I streamlined the IPC quite a bit. See the attached patch. Can be
> > applied on top of this patch.
> Sorry, I didn't look into actual code, but WRT the attached patch,
> wouldn't be better / possible to use
> pr_fmt() to print "intel_sgx:" prefix for all pr_*() ?
Would make much sense. I can do this. In any case Ineed to update this
series at least once more for the copyright platters. Thanks for the
Now that the series does not add anything intrusive (namely pipe exports
or use a fragile AES implementation) I would propose to pull the current
series as a single platform driver and move relevant code under arch/x86
in subsequent series.
I've taken great of making sure that it would be doable to move code
later on when I first decided to make it as a plaform driver. My
thinking has been that encapsulating the codebase to a driver would be
the least intrusive way to mainline the first version of the SGX support
for the Linux kernel especially when there isn't publicly available HW
to test it yet with launch control that makes sense for Linux.
I can write a detailed description to the documentation how the
implementation works in order to help to make the right decision for