Re: [RFC PATCH 0/9] media: base request API support
From: Alexandre Courbot
Date: Wed Dec 20 2017 - 04:27:58 EST
On Sat, Dec 16, 2017 at 6:04 AM, Nicolas Dufresne <nicolas@xxxxxxxxxxxx> wrote:
> Le vendredi 15 dÃcembre 2017 Ã 16:56 +0900, Alexandre Courbot a Ãcrit :
>> Here is a new attempt at the request API, following the UAPI we agreed on in
>> Prague. Hopefully this can be used as the basis to move forward.
>> This series only introduces the very basics of how requests work: allocate a
>> request, queue buffers to it, queue the request itself, wait for it to complete,
>> reuse it. It does *not* yet use Hans' work with controls setting. I have
>> preferred to submit it this way for now as it allows us to concentrate on the
>> basic request/buffer flow, which was harder to get properly than I initially
>> thought. I still have a gut feeling that it can be improved, with less back-and-
>> forth into drivers.
>> Plugging in controls support should not be too hard a task (basically just apply
>> the saved controls when the request starts), and I am looking at it now.
>> The resulting vim2m driver can be successfully used with requests, and my tests
>> so far have been successful.
>> There are still some rougher edges:
>> * locking is currently quite coarse-grained
>> * too many #ifdef CONFIG_MEDIA_CONTROLLER in the code, as the request API
>> depends on it - I plan to craft the headers so that it becomes unnecessary.
>> As it is, some of the code will probably not even compile if
>> CONFIG_MEDIA_CONTROLLER is not set
> Would it be possible to explain why this relation between request and
> the media controller ? Why couldn't request be created from video
> devices ?
Laurent replied on IRC, but for the record this is because the media
node can act as an orchestrator to the devices it manages. Some
devices may have particular needs in that respect, and we want to be
able to hook somewhere and control that.
Another reason is that in the future the media framework will probably
take more importance, to the point where you could control the whole
chain of devices through it instead of having to open every node
individually. This is a different topic though, and we only touched
the surface of it during the latest mini-summit.