Re: [PATCH v10 1/3] lib: Add strongly typed 64bit int_sqrt

From: Crt Mori
Date: Wed Dec 20 2017 - 11:18:24 EST


On 20 December 2017 at 17:00, Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote:
> On Wed, Dec 20, 2017 at 02:39:26PM +0000, David Laight wrote:
>
>> With minor changes it ought to be possible to remove most of the
>> 64bit arithmetic and shifts.
>>
>> If you care about performance then using 32 bit maths will be much faster.
>
> Some, u64 add/sub/shift isn't exactly expensive, but yes, I also
> indicated that improvement is possible. At the very least y can be made
> a u32 I suppose.

OK, is there any more easy optimizations you see?