Re: [PATCH AUTOSEL for 4.14 20/60] kbuild: re-order the code to not parse unnecessary variables

From: Greg KH
Date: Wed Dec 20 2017 - 12:13:27 EST

On Wed, Dec 13, 2017 at 01:55:15AM +0000, alexander.levin@xxxxxxxxxxx wrote:
> From: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> [ Upstream commit 2c1f4f125159f10521944cea23e33a00fcf85ede ]
> The top Makefile is divided into some sections such as mixed targets,
> config targets, build targets, etc.
> When we build mixed targets, Kbuild just invokes submake to process
> them one by one. In this case, compiler-related variables like CC,
> KBUILD_CFLAGS, etc. are unneeded.
> Check what kind of targets we are building first, and parse variables
> for building only when necessary.
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <alexander.levin@xxxxxxxxxxx>
> ---
> Makefile | 233 ++++++++++++++++++++++++++++++++-------------------------------
> 1 file changed, 118 insertions(+), 115 deletions(-)

While this is a "nice thing", I don't see how this is a good 4.14-stable patch.

It doesn't fix a bug, is really "big", and might make a build faster
(but does it even do that?)

So I'm going to drop this from the pull request you sent, thanks.

greg k-h