Re: [PATCH 1/2] x86/stacktrace: do not fail when regs on stack for ORC
From: Josh Poimboeuf
Date: Wed Dec 20 2017 - 12:45:50 EST
On Sun, Dec 17, 2017 at 09:37:49PM -0600, Josh Poimboeuf wrote:
> > So making it:
> > if (!(task->flags & (PF_KTHREAD | PF_IDLE)))
> > return -EINVAL;
> > works, but is not reliable now. So I believe, we cannot live without
> > unwind->error to differentiate between "unwind_done() == true" because:
> > * full stack unwound and the stack type is set to UNKNOWN
> > * unwinding failed and the stack type is set to UNKNOWN
> > Or perhaps introduce stack type BOTTOM, NONE, or NOMORE meaning the
> > bottom of the stacks reached?
> Yeah, we'll need something... I need to think about it a little more.
I can update the ORC unwinder to set unwind->error in case it runs into
an issue or it doesn't reach the "end", like the FP unwinder does.
It might not be until 2018 though. But in the meantime you can go ahead
and update your patches accordingly and then we can combine them for
testing next year.