Re: [PATCH 1/2] Revert "Bluetooth: btusb: fix QCA Rome suspend/resume"
From: Daniel Drake
Date: Thu Dec 21 2017 - 06:44:03 EST
On Wed, Dec 20, 2017 at 6:53 PM, Brian Norris <briannorris@xxxxxxxxxxxx> wrote:
> On Wed, Dec 20, 2017 at 07:00:07PM +0800, Kai-Heng Feng wrote:
> > This commit causes a regression on some QCA ROME chips. The USB device
> > reset happens in btusb_open(), hence firmware loading gets interrupted.
> Oh, did you really confirm that's the root of the problem? I was only
> hypothesizing, with some informed observation and code review; but I
> didn't fully convince myself. If so, that's interesting.
I have the same doubt. Can you explain how/why firmware uploading and
btusb_open() overlap, and how this is avoided with your patch?
If they do overlap, is that not a bug in the stack that should be fixed instead?
If the fix belongs in btusb and this BTUSB_RESET_RESUME thing really
is problematic, should it be totally removed instead?