Re: [PATCH 0/7] x86/platform/UV: UV Fix patches for Intel processors

[Ingo Molnar]

* Mike Travis <travis@xxxxxxx> wrote:

> 
> This patchset handles the fixes made to the UV4 HUB for upcoming Intel
> processors as there are some interface changes.
> 
>     * Update uv_mmrs.h to prep for fixed defines for UV4A.
> 
>     * Updates to handle UV4 vs. UV4A (fixed) arches.
> 
>     * Updates to handle UV4 GAM (global addressable memory) MMRs fixes.
> 
>     * Updates to handle UV4 BAU (broadcast assist unit) MMRs fixes.
> 
>     * Turn on UV4A_IS_SUPPORTED to enable code and header file fixes.

Sigh, has any of this been properly build tested? x86-64 allyesconfig produces a 
bunch of ugly warnings:

In file included from ./include/linux/kernel.h:14:0,
arch/x86/kernel/apic/x2apic_uv_x.c: In function âmap_mmioh_high_uv34â:
./include/linux/printk.h:308:2: warning: âidâ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:806:8: note: âidâ was declared here
In file included from ./include/linux/kernel.h:14:0,
./include/linux/printk.h:308:2: warning: âm_ioâ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:804:19: note: âm_ioâ was declared here
In file included from ./include/linux/kernel.h:14:0,
./include/linux/printk.h:308:2: warning: âshiftâ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:804:12: note: âshiftâ was declared here
arch/x86/kernel/apic/x2apic_uv_x.c:856:14: warning: ânâ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:846:9: warning: ânasid_maskâ may be used uninitialized in this function [-Wmaybe-uninitialized]
In file included from ./include/linux/kernel.h:14:0,
./include/linux/printk.h:308:2: warning: âbaseâ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:801:16: note: âbaseâ was declared here
arch/x86/kernel/apic/x2apic_uv_x.c:843:17: warning: âmmrâ may be used uninitialized in this function [-Wmaybe-uninitialized]
arch/x86/kernel/apic/x2apic_uv_x.c:832:16: warning: âoverlayâ may be used uninitialized in this function [-Wmaybe-uninitialized]

Thanks,

	Ingo