Re: pinctrl-amd: What hardware does it apply to?

From: Mika Westerberg
Date: Thu Dec 21 2017 - 07:13:05 EST

On Thu, Dec 21, 2017 at 11:11:18AM +0100, Linus Walleij wrote:
> > In contrast, the pinctrl-amd driver only mentions the newer KERNCZ platform
> > name and uses ACPI for probing without disclosing any Family or Model numbers.
> >
> > pinctrl-amd applies to "AMD0030" and "AMDI0030"
> >
> > The ACPI HID matching makes it difficult to determine what family and model the
> > driver applies to, or rather, I have not been able to find such a mapping of HIDs
> > to family and model numbers. It's also impossible to guess an ACPI _HID
> > that may or may not exist for the Family 16h Model 30h platform and even if I
> > allocate a new HID for our ACPI implementation, that HID has little hope of
> > being accepted into the mainline driver.
> I didn't understand anything of what you just wrote.
> I am basically ignorant when it comes to ACPI details.
> So let's CC the GPIO ACPI maintainer, Mika Westerberg.

If the hardware is not the same that is already supported by the
pinctrl-amd, then you definitely should allocate a new separate ACPI
_HID for it. That's pretty much what we do with every new SoC because
they typically don't have identical pin lists among other things.