Re: [PATCH v2] ARM: dts: sunxi: Add sid for a83t

From: Maxime Ripard
Date: Thu Dec 21 2017 - 09:55:30 EST


Hi Kyle,

On Tue, Dec 19, 2017 at 03:05:23PM -0600, kevans91@xxxxxxx wrote:
> Allwinner a83t has a 1 KB sid block with efuse for security rootkey and
> thermal calibration data, add node to describe it.
>
> a83t-sid is not currently supported by nvmem/sunxi-sid, but it is
> supported in an external driver for FreeBSD.
>
> Signed-off-by: Kyle Evans <kevans91@xxxxxxx>

The patch looks fine in itself, but we've had a number of issues with
the register layout (and access patterns) in the past, so I'd rather
have something that works in Linux too if possible.

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Attachment: signature.asc
Description: PGP signature