Re: [GIT PULL 1/3] ARM: dts: exynos: DTS for v4.16

[Arnd Bergmann]

On Wed, Dec 20, 2017 at 6:36 PM, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:

> Krzysztof Kozlowski (2):
>       ARM: dts: exynos: Add missing interrupt-controller properties to Exynos5410 PMU

I just looked through the remaining warnings in 4.15 and noticed that
you had sent this
only for 4.16, not as a bug fix.

Looking closer, it seems incorrect:

According to the comment added to exynos_dt_pmu_match[] in commit
8b283c025443 ("ARM: exynos4/5: convert pmu wakeup to stacked domains"),
the RTC is not able to wake up the system through the PMU on Exynos5410,
unlike Exynos5420. However, when the RTC DT node got added in commit
e1e146b1b062 ("ARM: dts: exynos: Add RTC and I2C to Exynos5410"), it was
a straight copy of the Exynos5420 node, which now causes the warning from dtc,
and now you add the "interrupt-controller" property to the device node, but
the code still doesn't handle it at all.

Can you have another look here?

        Arnd