Re: [PATCH v2] crypto: AF_ALG - limit mask and type

From: Herbert Xu
Date: Fri Dec 22 2017 - 02:59:03 EST

On Fri, Dec 22, 2017 at 08:41:10AM +0100, Stephan Mueller wrote:
> Shouldn't we then rather use a white list instead of a black list?
> >
> > Most other problems however would be bugs in the template code.
> > The first thing a template does when it creates an instance is
> > to check whether the resulting algorithm would fulfil the requested
> > type/mask using crypto_check_attr_type. So if that's not working
> > then we should fix it there as it may also be triggered via other
> > code paths that can create instances.
> I think I understand that, but does user space need to utilize this logic?

I'm open to a white list as well. But we should certainly fix
the underlying bugs rather than just papering over them as they
could come back via other channels.

Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key: