Re: [PATCH v3 2/3] hwrng: exynos - add Samsung Exynos True RNG driver

From: Marek Szyprowski
Date: Fri Dec 22 2017 - 03:29:49 EST


Hi,

On 2017-12-22 09:24, Herbert Xu wrote:
On Mon, Dec 04, 2017 at 01:53:50PM +0100, Åukasz Stelmach wrote:
Add support for True Random Number Generator found in Samsung Exynos
5250+ SoCs.

Signed-off-by: Åukasz Stelmach <l.stelmach@xxxxxxxxxxx>
This doesn't build for me:

CC [M] drivers/char/hw_random/exynos-trng.o
../drivers/char/hw_random/exynos-trng.c:230:1: error: \u2018exynos_rng_dt_match\u2019 undeclared here (not in a function)
../drivers/char/hw_random/exynos-trng.c:230:1: error: \u2018__mod_of__exynos_rng_dt_match_device_table\u2019 aliased to undefined symbol \u2018exynos_rng_dt_match\u2019
make[2]: *** [drivers/char/hw_random/exynos-trng.o] Error 1
make[1]: *** [_module_drivers/char/hw_random] Error 2

This looks like a missing dependency on "OF" when "COMPILE_TEST" is selected.

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland