Re: [PATCH -next] mtd: sharpslpart: make local function sharpsl_nand_cleanup_ftl() static
From: Andrea Adami
Date: Fri Dec 22 2017 - 05:09:40 EST
On Wed, Dec 20, 2017 at 6:45 AM, Wei Yongjun <weiyongjun1@xxxxxxxxxx> wrote:
> Fixes the following sparse warnings:
>
> drivers/mtd/parsers/sharpslpart.c:222:6: warning:
> symbol 'sharpsl_nand_cleanup_ftl' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> ---
> drivers/mtd/parsers/sharpslpart.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/parsers/sharpslpart.c b/drivers/mtd/parsers/sharpslpart.c
> index 0ddb79a..8893dc8 100644
> --- a/drivers/mtd/parsers/sharpslpart.c
> +++ b/drivers/mtd/parsers/sharpslpart.c
> @@ -219,7 +219,7 @@ static int sharpsl_nand_init_ftl(struct mtd_info *mtd, struct sharpsl_ftl *ftl)
> return ret;
> }
>
> -void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> +static void sharpsl_nand_cleanup_ftl(struct sharpsl_ftl *ftl)
> {
> kfree(ftl->log2phy);
> }
>
Thanks, this should be indeed static like the other functions.
Acked-by: Andrea Adami <andrea.adami@xxxxxxxxx>