Re: [PATCH v2 1/5] drm/panel: Add support for the EDT ETM0700G0BDH6

[Türk, Jan]

> Von: Rob Herring [mailto:robh@xxxxxxxxxx]
> Gesendet: Freitag, 22. Dezember 2017 00:00
> Betreff: Re: [PATCH v2 1/5] drm/panel: Add support for the EDT
> ETM0700G0BDH6
> 
> On Wed, Dec 20, 2017 at 02:47:01PM +0100, jan.tuerk@xxxxxxxxxxx wrote:
> > From: Jan Tuerk <jan.tuerk@xxxxxxxxxxx>
> >
> > The Emerging Display Technology ETM0700G0BDH6 is exactly the same
> > display as the ETM0700G0DH6, exept the pixelclock polarity. Therefore
> > re-use the ETM0700G0DH6 modes. It is used by default on emtrion Avari
> > based development kits.
> 
> As I asked on v1, why not document the panels together in a single doc?

As denoted in the cover letter:
>The documentation for the EDT display is kept as an extra file currently,
>as it is done by the most displays in the documentation. Also a new 
>new Variant of the EDT already arrived. So merging their documentations
>should be discussed separately.

I think it will be even a little tricky to find a matching filename for both versions,
as the recent ones adding an extra character in the description. Are you expecting sth. 
like edt,etm0700series.txt?

> 
> >
> > Signed-off-by: Jan Tuerk <jan.tuerk@xxxxxxxxxxx>
> > ---
> >  .../bindings/display/panel/edt,etm0700g0bdh6.txt          |  9 +++++++++
> >  drivers/gpu/drm/panel/panel-simple.c                      | 15 +++++++++++++++
> >  2 files changed, 24 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/panel/edt,etm0700g0bdh6.txt