Re: [PATCHv3] printk: add console_msg_format command line option

From: Petr Mladek
Date: Fri Dec 22 2017 - 09:30:32 EST


On Thu 2017-12-21 14:41:49, Sergey Senozhatsky wrote:
> This patch introduces a `console_msg_format=' command line option,
> to switch between different message formatting on serial consoles.
> For the time being we have just two options - default and syslog.
> The "default" option just keeps the existing format. While the
> "syslog" option makes serial console messages to appear in syslog
> format [syslog() syscall], matching the `dmesg -S --raw' and
> `cat /proc/kmsg' output formats:
>
> - facility and log level
> - time stamp (depends on printk_time/PRINTK_TIME)
> - message
>
> <%u>[time stamp] text\n
>

> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@xxxxxxxxx>
> Reviewed-by: Fengguang Wu <fengguang.wu@xxxxxxxxx>
> Reviewed-by: Kevin Hilman <khilman@xxxxxxxxxxxx>
> Tested-by: Kevin Hilman <khilman@xxxxxxxxxxxx>

The patch looks and works good for me.

Reviewed-by: Petr Mladek <pmladek@xxxxxxxx>

I am going to add it into for-4.16 branch when I am back in January.
The patch is basically innocent. But I do not want to eventually
screw up printk.git with a last minute commit.

Best Regards,
Petr