Re: Bug in patch "x86/pti: Add the pti= cmdline option and documentation"

From: Borislav Petkov
Date: Fri Dec 22 2017 - 11:43:53 EST


On Fri, Dec 22, 2017 at 05:41:32PM +0100, Juergen Gross wrote:
> The patch in the tip tree with commit 506bcdf68b07a0335751e1fe8be37
> ("x86/pti: Add the pti= cmdline option and documentation") is completely
> wrong: cmdline_find_option() will return -1 in case the otion isn't
> found and the len of the argument in case it has been found.

It is not completely wrong - we still walk into the if-branch. Besides,
we moved the xen check upwards, before that so it is not relevant for
the xen case.

Regardless, I'll send a correction soon to check the retval directly.

--
Regards/Gruss,
Boris.

SUSE Linux GmbH, GF: Felix ImendÃrffer, Jane Smithard, Graham Norton, HRB 21284 (AG NÃrnberg)
--