Re: [PATCH 07/45] drivers: infiniband: remove duplicate includes

From: Jason Gunthorpe
Date: Fri Dec 22 2017 - 11:45:37 EST


On Wed, Dec 06, 2017 at 10:19:39PM +0530, Pravin Shedge wrote:
> These duplicate includes have been found with scripts/checkincludes.pl but
> they have been removed manually to avoid removing false positives.
>
> Signed-off-by: Pravin Shedge <pravin.shedge4linux@xxxxxxxxx>
> drivers/infiniband/core/mad.c | 1 -
> drivers/infiniband/core/netlink.c | 2 --
> drivers/infiniband/hw/mlx5/main.c | 4 +---
> drivers/infiniband/hw/usnic/usnic_ib_sysfs.c | 1 -
> drivers/infiniband/hw/usnic/usnic_ib_verbs.c | 1 -
> 5 files changed, 1 insertion(+), 8 deletions(-)

I applied this to for-next, thanks

> index 543d0a4..fe435ed 100644
> +++ b/drivers/infiniband/hw/mlx5/main.c
> @@ -50,16 +50,14 @@
> #include <rdma/ib_cache.h>
> #include <linux/mlx5/port.h>
> #include <linux/mlx5/vport.h>
> +#include <linux/mlx5/fs.h>
> #include <linux/list.h>
> #include <rdma/ib_smi.h>
> #include <rdma/ib_umem.h>
> #include <linux/in.h>
> #include <linux/etherdevice.h>
> -#include <linux/mlx5/fs.h>
> -#include <linux/mlx5/vport.h>
> #include "mlx5_ib.h"
> #include "cmd.h"
> -#include <linux/mlx5/vport.h>

Yep, ugh.

Jason