Re: ptrace versus setuid changes in 4.14?

From: Kees Cook
Date: Fri Dec 22 2017 - 18:14:33 EST


On Fri, Dec 22, 2017 at 12:55 PM, Tom Horsley <horsley1953@xxxxxxxxx> wrote:
> On Fri, 22 Dec 2017 12:28:25 -0800
> Laura Abbott wrote:
>
>> Assuming this is https://bugzilla.redhat.com/show_bug.cgi?id=1528633
>> This is yet another victim of
>>
>> commit e37fdb785a5f95ecadf43b773c97f676500ac7b8 (refs/bisect/bad)
>> Author: Kees Cook <keescook@xxxxxxxxxxxx>
>> Date: Tue Jul 18 15:25:31 2017 -0700
>>
>> exec: Use secureexec for setting dumpability
>
> You mean there is hope this really is a bug and not a security
> enhancement? Amazing :-).
>
> And yes, that is the bugzilla I submitted after I reduced
> things to a small test program.

I think the secureexec dumpability logic just needs to be removed --
the logic in commit_creds() _should_ be sufficient, but I want to
double-check it now that I've got some more tests cases.

-Kees

--
Kees Cook
Pixel Security