Re: [PATCH] mm/sparse.c: Wrong allocation for mem_section

From: Kirill A. Shutemov
Date: Sat Dec 23 2017 - 04:54:40 EST


On Fri, Dec 22, 2017 at 04:48:18PM +0800, Baoquan He wrote:
> In commit
>
> 83e3c48729 "mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y"
>
> mem_section is allocated at runtime to save memory. While it allocates
> the first dimension of array with sizeof(struct mem_section). It costs
> extra memory, should be sizeof(struct mem_section*).
>
> Fix it.
>
> Signed-off-by: Baoquan He <bhe@xxxxxxxxxx>
> Tested-by: Dave Young <dyoung@xxxxxxxxxx>
> Cc: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Cc: Andy Lutomirski <luto@xxxxxxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Atsushi Kumagai <ats-kumagai@xxxxxxxxxxxxx>
> Cc: linux-mm@xxxxxxxxx

Ughh. Sorry.

Acked-by: Kirill A. Shutemov <kirill.shutemov@xxxxxxxxxxxxxxx>

Please queue it to stable.

--
Kirill A. Shutemov