RE: [PATCH] ASoC: max98373: Added Amplifier Driver

[Ryan Lee]

Hi Philppe Ombredanne,

>-----Original Message-----
>From: Philippe Ombredanne [mailto:pombredanne@xxxxxxxx]
>Sent: Friday, December 22, 2017 12:39 AM
>To: Ryan Lee <RyanS.Lee@xxxxxxxxxxxxxxxxxxx>
>Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>; Mark <broonie@xxxxxxxxxx>;
>Rob Herring <robh+dt@xxxxxxxxxx>; Mark Rutland <mark.rutland@xxxxxxx>;
>Jaroslav Kysela <perex@xxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Arnd
>Bergmann <arnd@xxxxxxxx>; afd@xxxxxx; robert.jarzmik@xxxxxxx;
>supercraig0719@xxxxxxxxx; jbrunet@xxxxxxxxxxxx; dannenberg@xxxxxx;
>Romain Perier <romain.perier@xxxxxxxxxxxxx>;
>bryce.ferguson@xxxxxxxxxxxxxxxxxxx; kuninori.morimoto.gx@xxxxxxxxxxx; m-
>stecklein@xxxxxx; ALSA <alsa-devel@xxxxxxxxxxxxxxxx>; open list:OPEN
>FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
><devicetree@xxxxxxxxxxxxxxx>; LKML <linux-kernel@xxxxxxxxxxxxxxx>;
>ryan.lee.maxim@xxxxxxxxx
>Subject: Re: [PATCH] ASoC: max98373: Added Amplifier Driver
>
>EXTERNAL EMAIL
>
>
>
>Ryan,
>
>On Fri, Dec 22, 2017 at 2:43 AM, Ryan Lee <ryans.lee@xxxxxxxxxxxxxxxxxxx>
>wrote:
>> Signed-off-by: Ryan Lee <ryans.lee@xxxxxxxxxxxxxxxxxxx>
>> ---
>>
>> Created max98373 amplifier driver.
>>
>
><snip>
>
>> --- /dev/null
>> +++ b/sound/soc/codecs/max98373.c
>> @@ -0,0 +1,996 @@
>> +/*
>> + * max98373.c  --  MAX98373 ALSA Soc Audio driver
>> + *
>> + * Copyright (C) 2017 Maxim Integrated Products
>> + * Author: Ryan Lee <ryans.lee@xxxxxxxxxxxxxxxxxxx>
>> + *
>> + *  This program is free software; you can redistribute  it and/or
>> +modify it
>> + *  under  the terms of  the GNU General  Public License as published
>> +by the
>> + *  Free Software Foundation;  either version 2 of the  License, or
>> +(at your
>> + *  option) any later version.
>> + */
>
>Have you considered using the new SPDX tags instead of this fine but long
>legalese?
>
>And if other contributors in your team could follow suit and you could spread
>the word that would be even better!
>
>See Thomas doc patches [1] for details.
>Thanks!
>
>[1]
>https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flkml.org%
>2Flkml%2F2017%2F12%2F4%2F934&data=01%7C01%7Cryans.lee%40maximint
>egrated.com%7Cd26ec4859b2240fb0a6008d549178c4f%7Cfbd909dfea69478
>8a554f24b7854ad03%7C0&sdata=dTVH044XPox7EPR0WU1IGMlLxaWBDl80%
>2B%2FVYhwu51y0%3D&reserved=0
>
Thanks for your feedback. I will follow this.
>--
>Cordially
>Philippe Ombredanne