Re: [PATCH/RFC] perf report: Add option to change offset format when address is specified as a sort_key

[Jiri Olsa]

On Sun, Dec 24, 2017 at 06:23:15PM +0000, Aaron Tomlin wrote:
> On Sat 2017-12-23 00:59 +0100, Jiri Olsa wrote:
> [ ... ]
> > not sure we've already discussed that, but this could be default?
> 
> Probably it is best to keep the default behaviour.
> 
> I'd prefer a hexadecimal address offset, as the default, however perhaps
> someone is happy with the current default (decimal).

Arnaldo?

> 
> > if not, I think the hex option should be part of -g option arg, maybe like:
> 
> Does it have to be?
> 
> >   -g graph,callee,xaddress
> 
> Not sure - adding another sort_key seems odd to me.

it's not sort key, it's -g option key.. but if we go for default
there's no need.. let's see ;-)

> 
> But if you insist, perhaps address[=hex] would be cleaner?

but yes, that looks better to me

jirka