Re: [PATCH v2] ARM: dts: ls1021a: add support for Moxa UC-8410A open platform

From: Shawn Guo
Date: Mon Dec 25 2017 - 22:56:21 EST

On Mon, Dec 11, 2017 at 07:51:25PM +0800, SZ Lin wrote:
> Add support for Moxa UC-8410A open platform
>
> The UC-8410A computing platform is designed
> for embedded communication-centric industrial applications
>
> The features of UC-8410A are:
> * QSPI flash
> * SD slot
> * 3x LAN
> * 8x RS-232/422/485 ports, software-selectable
> * Mini PCIe form factor with PCIe/USB signal
> * 2x USB host
> * TPM
> * Watchdog
> * RTC
> * User LEDs
> * Beeper
> * Push button
>
> Signed-off-by: Jimmy Chen <jimmy.chen@xxxxxxxx>
> Signed-off-by: Harry YJ Jhou <harryyj.jhou@xxxxxxxx>
> Signed-off-by: SZ Lin <sz.lin@xxxxxxxx>
>
> --
> Changes from v1:
> - Add newline between nodes
> - Add push button node
> - Insert newline between property list and child node
> - Include file of "include/dt-bindings/gpio/gpio.h"
> - Include file of "include/dt-bindings/input/input.h"
> - Use polartiy defines for gpios to make it more readable
> - Put 'status' at the end of property list
> - Change GPIO pin number in cel_pwr and cel_reset
> - Sort the labeled node alphabetically
> - Drop container node of regulator and put fixed regulator directly
> under root
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts | 241 ++++++++++++++++++++++++++++
> 2 files changed, 242 insertions(+)
> create mode 100644 arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index d0381e9caf21..62ce9b27ad30 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -520,6 +520,7 @@ dtb-$(CONFIG_SOC_IMX7D) += \
> imx7s-colibri-eval-v3.dtb \
> imx7s-warp.dtb
> dtb-$(CONFIG_SOC_LS1021A) += \
> + ls1021a-moxa-uc-8410a.dtb \
> ls1021a-qds.dtb \
> ls1021a-twr.dtb
> dtb-$(CONFIG_SOC_VF610) += \
> diff --git a/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
> new file mode 100644
> index 000000000000..bc73b5187990
> --- /dev/null
> +++ b/arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts
> @@ -0,0 +1,241 @@
> +/*
> + * Copyright (C) 2017 Moxa Inc. - https://www.moxa.com/
> + *
> + * Author: Harry YJ Jhou (åäè) <harryyj.jhou@xxxxxxxx>
> + * Jimmy Chen (éæé) <jimmy.chen@xxxxxxxx>
> + * SZ Lin (æäæ) <sz.lin@xxxxxxxx>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +
> +/dts-v1/;
> +
> +#include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
> +#include "ls1021a.dtsi"
> +
> +/ {
> + model = "Moxa UC-8410A";
> +
> + aliases {
> + enet0_rgmii_phy = &rgmii_phy0;
> + enet1_rgmii_phy = &rgmii_phy1;
> + enet2_rgmii_phy = &rgmii_phy2;
> + };
> +
> + sys_mclk: clock-mclk {
> + compatible = "fixed-clock";
> + #clock-cells = <0>;
> + clock-frequency = <24576000>;
> + };
> +
> + reg_3p3v: regulator-3p3v {
> + compatible = "regulator-fixed";
> + regulator-name = "3P3V";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + cel_pwr {

We generally use hyphen rather than underscore in node name.

> + label = "UC8410A:CEL-PWR";
> + gpios = <&gpio3 27 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> +
> + cel_reset {
> + label = "UC8410A:CEL-RESET";
> + gpios = <&gpio3 28 GPIO_ACTIVE_LOW>;
> + default-state = "off";
> + };
> +
> + str_led {
> + label = "UC8410A:RED:PROG";
> + gpios = <&gpio0 16 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "mmc0";
> + };
> +
> + sw_ready {
> + label = "UC8410A:GREEN:SWRDY";
> + gpios = <&gpio0 18 GPIO_ACTIVE_HIGH>;
> + default-state = "on";
> + };
> +
> + beeper {
> + label = "UC8410A:BEEP";
> + gpios = <&gpio0 20 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> +
> + prog_led0 {
> + label = "UC8410A:GREEN:PROG2";
> + gpios = <&gpio3 14 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> +
> + prog_led1 {
> + label = "UC8410A:GREEN:PROG1";
> + gpios = <&gpio3 15 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> +
> + prog_led2 {
> + label = "UC8410A:GREEN:PROG0";
> + gpios = <&gpio3 16 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> +
> + wifi_signal0 {
> + label = "UC8410A:GREEN:CEL2";
> + gpios = <&gpio3 17 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> +
> + wifi_signal1 {
> + label = "UC8410A:GREEN:CEL1";
> + gpios = <&gpio3 18 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> +
> + wifi_signal2 {
> + label = "UC8410A:GREEN:CEL0";
> + gpios = <&gpio3 19 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> +
> + cpu_diag_red {
> + label = "UC8410A:RED:DIA";
> + gpios = <&gpio3 20 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> +
> + cpu_diag_green {
> + label = "UC8410A:GREEN:DIA";
> + gpios = <&gpio3 21 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> +
> + cpu_diag_yellow {
> + label = "UC8410A:YELLOW:DIA";
> + gpios = <&gpio3 22 GPIO_ACTIVE_HIGH>;
> + default-state = "off";
> + };
> + };
> +
> + gpio-keys {
> + compatible = "gpio-keys";
> +
> + pushbtn-key {
> + label = "push button key";
> + gpios = <&gpio1 21 GPIO_ACTIVE_LOW>;
> + linux,code = <BTN_MISC>;
> + default-state = "on";
> + };
> + };
> +};
> +
> +&enet0 {
> + phy-handle = <&rgmii_phy0>;
> + phy-connection-type = "rgmii-id";
> + status = "okay";
> +};
> +
> +&enet1 {
> + phy-handle = <&rgmii_phy1>;
> + phy-connection-type = "rgmii-id";
> + status = "okay";
> +};
> +
> +&enet2 {
> + phy-handle = <&rgmii_phy2>;
> + phy-connection-type = "rgmii-id";
> + status = "okay";
> +};
> +
> +&i2c0 {
> + clock-frequency = <100000>;
> + status = "okay";
> +
> + rtc {

Nodes with 'reg' property should have a match unit-address after node name.

> + compatible = "dallas,ds1374";
> + reg = <0x68>;
> + };
> +
> + tpm {

Sort nodes with unit-address in order of the address.

> + compatible = "infineon,slb9635tt";
> + reg = <0x20>;
> + };
> +};
> +
> +&lpuart0 {
> + status = "okay";
> +};
> +
> +&mdio0 {
> + rgmii_phy0: ethernet-phy@0 {
> + compatible = "marvell,88e1118";
> + reg = <0x0>;
> + marvell,reg-init =
> + <3 0x11 0 0x4415>, /* Reg 3,17 */
> + <3 0x10 0 0x77>; /* Reg 3,16 */
> + };
> +
> + rgmii_phy1: ethernet-phy@1 {
> + compatible = "marvell,88e1118";
> + reg = <0x1>;
> + marvell,reg-init =
> + <3 0x11 0 0x4415>, /* Reg 3,17 */
> + <3 0x10 0 0x77>; /* Reg 3,16 */
> + };
> +
> + rgmii_phy2: ethernet-phy@2 {
> + compatible = "marvell,88e1118";
> + reg = <0x2>;
> + marvell,reg-init =
> + <3 0x11 0 0x4415>, /* Reg 3,17 */
> + <3 0x10 0 0x77>; /* Reg 3,16 */
> + };
> +};
> +
> +&qspi {
> + bus-num = <0>;
> + fsl,spi-num-chipselects = <2>;
> + fsl,spi-flash-chipselects = <0>;
> + fsl,qspi-has-second-chip;
> + status = "okay";
> +
> + flash: flash@0 {
> + compatible = "spansion,s25fl064l", "spansion,s25fl164k";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + spi-max-frequency = <20000000>;
> + reg = <0>;
> +
> + partitions@0 {
> + label = "U-Boot";
> + reg = <0x0 0x180000>;
> + };
> +
> + partitions@1 {

The unit-address doesn't match 'reg' property.

Shawn

> + label = "U-Boot Env";
> + reg = <0x180000 0x680000>;
> + };
> + };
> +};
> +
> +&sata {
> + status = "okay";
> +};
> +
> +&uart0 {
> + status = "okay";
> +};
> +
> +&uart1 {
> + status = "okay";
> +};
> --
> 2.15.1
>