Re: [PATCH 0/1] Input: inline macros for MODULE_LICENSE, etc

From: Julia Lawall
Date: Tue Dec 26 2017 - 13:10:55 EST




On Tue, 26 Dec 2017, Joe Perches wrote:

> On Tue, 2017-12-26 at 18:05 +0100, Julia Lawall wrote:
> > Inline macro for MODULE_LICENSE to make the license information easy to
> > find, eg with grep. Inline the other module-related macros at the same
> > time.
>
> Perhaps it'd be better to not make this
> dependent on a MODULE_LICENSE use, but allow
> any #define foo/#define MODULE_<FOO> foo
> where foo is used once to be converted.

Well, I wanted something that could be checked in a finite (small) amount
of time... There seemed to be a slightly more compelling argument for
inlining the license, so I decided to focus on that. What you suggested
resulted in around 5000 lines of patch code, mostly inlining authors and
descriptions.

But maybe you have already done the things done in my patch and it hasn't
been picked up yet?

julia