Re: [PATCH v5 06/78] xarray: Change definition of sibling entries

From: Kirill A. Shutemov
Date: Wed Dec 27 2017 - 05:26:13 EST


On Tue, Dec 26, 2017 at 07:13:26PM -0800, Matthew Wilcox wrote:
> On Tue, Dec 26, 2017 at 08:21:53PM +0300, Kirill A. Shutemov wrote:
> > > +/**
> > > + * xa_is_internal() - Is the entry an internal entry?
> > > + * @entry: Entry retrieved from the XArray
> > > + *
> > > + * Return: %true if the entry is an internal entry.
> > > + */
> >
> > What does it mean "internal entry"? Is it just a term for non-value and
> > non-data pointer entry? Do we allow anybody besides xarray implementation to
> > use internal entires?
> >
> > Do we have it documented?
>
> We do! include/linux/radix-tree.h has it documented right now:

Looks good. Thanks.

--
Kirill A. Shutemov