Re: [PATCH] objtool: Fix clang enum conversion warning
From: Ingo Molnar
Date: Thu Dec 28 2017 - 07:09:55 EST
* Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> On Wed, Dec 27, 2017 at 10:42:45PM -0500, Nick Desaulniers wrote:
> > On Wed, Dec 27, 2017 at 12:38 PM, Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:
> > > On Wed, Dec 27, 2017 at 01:34:34PM +0100, Lukas Bulwahn wrote:
> > >> Assuming that the authorship of this one-line change does not matter, as it
> > >> is largely suggested by the clang compiler anyway, and we want to move the
> > >> change forward, we should decide on which of three patches to move
> > >> forward. I can give my Reviewed-by and Tested-by to any of them.
> >
> > I suppose Ingo would take the first and accumulate Reviewed-By tags.
> > I don't particularly care about authorship (please just fix the bug).
> >
> > > The patch from Lukas was the first one I received, so that's the one I
> > > used. I rewrote the commit msg for clarity and added my SOB and sent it
> > > to Ingo for merging.
> >
> > I think you should have kept Nicholas Mc Guire's Reviewed by tag?
> > Maybe Ingo can re-add his and mine when merging?
>
> Yes, sorry, I missed that one.
>
> Ingo, can you please add the following?
>
> Reviewed-by: Nicholas Mc Guire <der.herr@xxxxxxx>
> Reviewed-by: Nick Desaulniers <nick.desaulniers@xxxxxxxxx>
Sure, done!
Thanks,
Ingo