Re: [regression] Re: Thinkpad T40p: suspend to ram stopped working sometime before 4.14

[Pavel Machek]

Hi!

> > > > > > Ok, so suspend looks ok. On resume, "moon" LED goes off and power /
> > > > > > bluetooth LEDs go on, but screen is black and no response to
> > > > > > > > > anything.
> > > > > 
> > > > > And it seems bad commit is
> > > > > 
> > > > > commit 5620a0d1aacd554ebebcff373e31107bb1ef7769
> > > > > Author: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> > > > > Date:   Thu Sep 14 14:23:01 2017 -0700
> > > > > 
> > > > >     firmware: delete in-kernel firmware
> > > > > 
> > > > > Unfortuantely, it does not revert cleanly.
> > > > 
> > > > I can't, because there's df85b2d767aad90fd2746f993fcd66dd322768f8 on
> > > > top of it, partialy reverting it. Seems like 5620 was causing problems
> > > > for other people before.
> > > > 
> > > > And then there's huge mega-patch called "license cleanup" on top of
> > > > that, which changes 11100 files (!) and makes work harder still.
> > > > 
> > > > Can we go for full revert?
> > > 
> > > No, it does not make any sense. 
> > > Could you please post your config? 
> > 
> > Well.. neither makes the original commit message any sense :-(.
> > 
> > CONFIG_PREVENT_FIRMWARE_BUILD=y
> > CONFIG_FW_LOADER=y
> > CONFIG_FIRMWARE_IN_KERNEL=y
> > CONFIG_EXTRA_FIRMWARE="radeon/R700_rlc.bin iwlwifi-1000-5.ucode"
> > CONFIG_EXTRA_FIRMWARE_DIR="/lib/firmware"
> 
> Looks like a pilot error to me. You have a R200 card, but you load R700
> firmware. Try:
> CONFIG_EXTRA_FIRMWARE="radeon/R200_cp.bin iwlwifi-1000-5.ucode"
> instead.

So... With modified extra firmware line, it works for me. Good.

But... it worked before. So that's still a regression and hard to
debug one, and probably going to happen to more users than just
me. Yeah, pilot landed on wrong runway, but this should not lead to
his engines exploding and black box being erased.

What is going on there? Why did it work before?

Is there way we could warn during boot (or suspend) "hey, you need
this firmware for resume"?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature