Re: [PATCH 2/2] Staging: most: aim-sound: sound.c: removed unnecessary parentheses

[Ozgur]

29.12.2017, 02:07, "Philippe Loctaux" <loctauxphilippe@xxxxxxxxx>:
> Removed unnecessary parentheses in a if statement.
>
> Signed-off-by: Philippe Loctaux <loctauxphilippe@xxxxxxxxx>
> ---
> Âdrivers/staging/most/aim-sound/sound.c | 2 +-
> Â1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/most/aim-sound/sound.c b/drivers/staging/most/aim-sound/sound.c
> index ab2b0d833..0e79a4898 100644
> --- a/drivers/staging/most/aim-sound/sound.c
> +++ b/drivers/staging/most/aim-sound/sound.c
> @@ -166,7 +166,7 @@ static struct channel *get_channel(struct most_interface *iface,
> ÂÂÂÂÂÂÂÂÂstruct channel *channel, *tmp;
>
> ÂÂÂÂÂÂÂÂÂlist_for_each_entry_safe(channel, tmp, &dev_list, list) {
> - if ((channel->iface == iface) && (channel->id == channel_id))
> + if (channel->iface == iface && channel->id == channel_id)
> ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂreturn channel;
> ÂÂÂÂÂÂÂÂÂ}

Hello,

I think this patch is not good, the code will not work. Please should understand in && operator and () why used with C.

Ozgur

> --
> 2.15.1